Persist bash history in devcontainer #4389
Conversation
|
@SteveMacenski what's up with the tests now 😭 Why is this showing up now |
Welcome to my life as a Nav2 maintainer 🙃 😆 |
|
@SteveMacenski I added one more thing: auto-sourcing of overlay if it exists, otherwise source underlay |
|
In my own projects I generate docker images for every PR to be able to easily "checkout" a PR (code + environment). I guess we don't do that here right? It would have helped me test this PR better. Is this an idea you'd be open to? If you're worried about CI time, it can be triggered manually |
nav2_bashrc
Outdated
| @@ -0,0 +1,14 @@ | |||
| OVERLAY_DIR=/opt/overlay_ws | |||
There was a problem hiding this comment.
This should be in /tools not in the root of the repository please
There was a problem hiding this comment.
Ah nice, I was looking for a better place
There was a problem hiding this comment.
/tools is our catch-all for random developer tools
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
| source $UNDERLAY | ||
| fi | ||
|
|
||
| # https://code.visualstudio.com/remote/advancedcontainers/persist-bash-history |
There was a problem hiding this comment.
I see the vscode docs recommends to bake this into the Dockerfile, but I think that's just adds unnecessary opportunities to bust the docker layer cache when it doesn't have to. Please add such user session config to the postCreateCommand where we already manage things like .bashrc.
navigation2/.devcontainer/post-create-command.sh
Lines 10 to 11 in d302f1a
| # https://docs.ros.org/en/rolling/Tutorials/Workspace/Creating-A-Workspace.html#source-the-overlay | ||
| OVERLAY=$OVERLAY_DIR/install/setup.bash | ||
| UNDERLAY=/opt/ros/${ROS_DISTRO}/setup.bash | ||
| if [ -f "$OVERLAY" ]; then |
There was a problem hiding this comment.
Don't think we should add this kind of logic to a one off script. Let's add an alias to the .bashrc instead, as we still may need to open a shell without automatically sourcing a workspace.
There was a problem hiding this comment.
as we still may need to open a shell without automatically sourcing a workspace
I'm curious to know which use cases would be affected by the auto-sourcing of the workspace?
Adding an alias to the bashrc doesn't add much more value to manually doing it (once it's done once and in the bash history, it's easy to pull up).
| }, | ||
| { | ||
| "source": "nav2-bashhistory", | ||
| "target": "/commandhistory", |
There was a problem hiding this comment.
When I overhaul the user account setup for the devcontainer, we can track such dot files easier than using root level paths.
Signed-off-by: Tony Najjar <[email protected]>
|
@ruffsl if you can incorporate the idea of a persistent bash history in your PR I'm happy to close this. |
Feel free to give it a try, I generalized it for any dotfile under the default home directory inside the devcontainer: I prefer to use fish shell or sometime zsh, so this work for those use cases too. |
|
Will give it a try as soon as I can! |
Persist the bash history of devcontainer in a local volume